-
Notifications
You must be signed in to change notification settings - Fork 986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correct encoding of make_program path for AutoTools + msys2 #15047
base: develop
Are you sure you want to change the base?
Correct encoding of make_program path for AutoTools + msys2 #15047
Conversation
Autotools expects to be run in a unix-like environment. So the correct encoding for paths to execute is unix-like.
Thanks very much for your PR! |
In 5b33028 I have reduced the test so it runs in a few seconds, and still covers the use case. However, I am a bit concerned about the change:
Please let me know what you think. |
They can also specify "bash:path" with the syntax they want (in system or "unix_path" syntax), and autotools works correctly. That's the expected behavior I am trying to replicate.
Agreed. If the user is providing the path manually, they can conform to a required syntax. However, this path is being supplied programmatically in by
and it seems like that syntax should result in a valid path. Of secondary consideration, trying to script this in windows tools (such as powershells
You're right, I think 922cb85 is a cleaner approach.
It's definitely possible to have a The user has the option of using their profile to configure the package they would like to provide "tools.gnu:make_program", which seems a sensible path since that configuration would be alongside the configuration of "bash:path" and "bash:subsystem".
|
Changelog: (Bugfix): AutoTools Describe here your pull request (fixes #15046)
develop
branch, documenting this one.I'd be happy to, but I'm not sure what docs would need to be updated